Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#321 todo removed #340

Merged
merged 1 commit into from
Oct 6, 2014
Merged

#321 todo removed #340

merged 1 commit into from
Oct 6, 2014

Conversation

longtimeago
Copy link
Contributor

No description provided.

@longtimeago longtimeago mentioned this pull request Oct 5, 2014
Closed
@davvd
Copy link
Collaborator

davvd commented Oct 6, 2014

Thanks, I'll ask someone to do a code review here, thanks for your pull request

@davvd
Copy link
Collaborator

davvd commented Oct 6, 2014

@krzyk could you please review this pull request

@davvd davvd added the @krzyk label Oct 6, 2014
@krzyk
Copy link
Contributor

krzyk commented Oct 6, 2014

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Oct 6, 2014

@rultor merge

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3b5f214 into yegor256:master Oct 6, 2014
@rultor
Copy link
Collaborator

rultor commented Oct 6, 2014

@rultor merge

@krzyk Done! FYI, the full log is here (took me 16min)

@longtimeago longtimeago deleted the 321 branch October 6, 2014 16:44
@davvd
Copy link
Collaborator

davvd commented Oct 7, 2014

@krzyk I just added 17 mins to your account, many thanks for your contribution..

@davvd
Copy link
Collaborator

davvd commented Oct 7, 2014

@rultor please deploy

@rultor
Copy link
Collaborator

rultor commented Oct 7, 2014

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Oct 7, 2014

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 9min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@krzyk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@longtimeago @davvd @krzyk @rultor