Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should retrieve DyTxn #472

Merged
merged 6 commits into from
Dec 3, 2014
Merged

Should retrieve DyTxn #472

merged 6 commits into from
Dec 3, 2014

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Dec 1, 2014

refs #464

@davvd
Copy link
Collaborator

davvd commented Dec 2, 2014

Many thanks for the PR, let me find a reviewer for it

@davvd
Copy link
Collaborator

davvd commented Dec 2, 2014

@krzyk it's yours, please review

@caarlos0
Copy link
Contributor Author

caarlos0 commented Dec 2, 2014

How should I align DyBaseTest.java line 95?

@krzyk
Copy link
Contributor

krzyk commented Dec 2, 2014

@caarlos0 it should be one indentation more than the previous method call, qulice should report exact number of spaces

@caarlos0
Copy link
Contributor Author

caarlos0 commented Dec 2, 2014

@krzyk well, seems like a really weird identation...

ERROR] /src/test/java/com/thindeck/dynamo/DyBaseTest.java[95]: method call rparen at indentation level 16 not at correct indentation, 12 (IndentationCheck)

@krzyk
Copy link
Contributor

krzyk commented Dec 2, 2014

@caarlos0 yes I know, it looks somehow better when you move the first method call to the previous line

@caarlos0
Copy link
Contributor Author

caarlos0 commented Dec 2, 2014

@krzyk done.

@krzyk
Copy link
Contributor

krzyk commented Dec 3, 2014

@rultor merge pls

@rultor
Copy link
Collaborator

rultor commented Dec 3, 2014

@rultor merge pls

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 356a5a3 into yegor256:master Dec 3, 2014
@rultor
Copy link
Collaborator

rultor commented Dec 3, 2014

@rultor merge pls

@krzyk Done! FYI, the full log is here (took me 13min)

@caarlos0 caarlos0 deleted the 464 branch December 3, 2014 10:40
@davvd
Copy link
Collaborator

davvd commented Dec 4, 2014

@krzyk Much appreciated! 22 mins was added to your account, payment ID 48470683

@davvd
Copy link
Collaborator

davvd commented Dec 4, 2014

@rultor please deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants