Columns with white space #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 4 4
Lines 277 277
=======================================
Hits 261 261
Misses 16 16 ☔ View full report in Codecov by Sentry. |
|
This would be a huge addition. I have a dataframe that is slow to write with Pandas and I want to use BCP -- but it has columns with white spaces in the names and it would break a lot downstream if I change those. @yehoshuadimarsky could this be reviewed + merged? |
|
please fix the merge conflicts first |
|
@jacobshaw42 can you please address the merge conflicts that have developed? |
|
@yehoshuadimarsky @sfirke Merge conflict resolved |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #30 without having to change column names