Swift4.2 #168
Merged
Swift4.2 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lated unexpected behavior
akifuji
reviewed
Sep 25, 2018
| p.pointee | ||
| } | ||
| return _HDKey(privateKey: result, | ||
| publicKey: result, |
There was a problem hiding this comment.
Are really both of privateKey and publicKey the same value?
There was a problem hiding this comment.
Oh this is kind of bad architecture of _HDKey.
I think _HDKey should be refactored, but it's not in the scope of this PR.
akifuji
reviewed
Sep 25, 2018
| @@ -104,6 +104,12 @@ class MockHelperTests: XCTestCase { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func testP2SHRecursively() { | |||
There was a problem hiding this comment.
I don't think this test is necessary. If it is, please comment for the reason.
akifuji
reviewed
Sep 25, 2018
| @@ -0,0 +1,24 @@ | |||
| // | |||
| // SerializationTests.swift | |||
|
Is there anything else that prevents this PR from being merged? |
|
@DevilDimon Sorry for long time absence. Will merge this branch. |
usatie
commented
Sep 11, 2019
| @@ -140,11 +143,11 @@ public class _HDKey { | |||
| data.append(0) // padding | |||
| data += privateKey ?? Data() | |||
There was a problem hiding this comment.
If privateKey is nil, it should return nil
- Return nil if index is greater than 0x80000000 - Return nil if hardend but has no private key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Converted from Swift 4.1.2 to 4.2
Alternate Designs
Do nothing.
Benefits
Modern language.
Possible Drawbacks
Users who are using Xcode 9.0 or older cannot use BitcoinKit.
I'm not sure about this.
Applicable Issues
closes #163