Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type error in DiffToolkit #11

Closed
dktcoding opened this issue Sep 8, 2019 · 1 comment
Closed

Type error in DiffToolkit #11

dktcoding opened this issue Sep 8, 2019 · 1 comment

Comments

@dktcoding
Copy link

There's bug in:

diff-match-patch/src/DiffToolkit.php

Line 193 in ddbf7c0

if (mb_strlen($hm1[4] > $hm2[4])) {

This should be:

 if (mb_strlen($hm1[4]) > mb_strlen($hm2[4])) {
dktcoding added a commit to RiddlerArgentina/diff-match-patch that referenced this issue Sep 8, 2019
@dktcoding
Misc Code improvements:
f83e0ad 
- Fix yetanotherape#11
- Add declare(strict_types=1);
- Add types to all functions
- Improve formatting
- Use string format instead of concat
- Use proper types for comparison
- Rename commontOverlap to commonOverlap
- Change count() == 0 in favor of empty()
- Finalize classes
@yetanotherape yetanotherape mentioned this issue Sep 28, 2019
Merged
@yetanotherape
Copy link
Owner

@dktcoding thank you for spotting the bug!

yetanotherape added a commit that referenced this issue Sep 28, 2019
@yetanotherape
Merge pull request #12 from yetanotherape/fix-issue-11-type-error
463b635 
Fix issue #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yetanotherape @dktcoding