Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to php 8.0 #18

Merged
merged 6 commits into from
Dec 20, 2020
Merged

Conversation

ernst77
Copy link

@ernst77 ernst77 commented Dec 10, 2020

Minimal changes, I've only added er to the Match class and match variables.
Also upadted phpUnit to the version that supports php 8.0, because of this had to drop support for older php versions.
I guess it's okay as older PHP versions are not supported anymore...

@ernst77 ernst77 mentioned this pull request Dec 10, 2020
@yetanotherape
Copy link
Owner

Hi Ernest! Thank you for your effort.

I see that old PHP versions are still in use and I think it's better to add support of PHP 8 without dropping support for the old ones.

@ernst77
Copy link
Author

ernst77 commented Dec 10, 2020 via email

@yetanotherape
Copy link
Owner

Hmm... I'll try to read about this. Actually, I migrated to Python as a main language and don't follow PHP news 😄

@ernst77
Copy link
Author

ernst77 commented Dec 10, 2020

No worries, when you have time...
Well PHP language is moving quite quickly nowadays, I work constantly on it and cannot keep it up 😄
Link to phpUnit Issue

@thirsch
Copy link

thirsch commented Dec 17, 2020

Well, I think all the older versions and hhvm can be dropped. Don't think that there is a big issue, if a new major version just supports >= 7.3. If there is really a fix to be made in the classes, there is always the possibility for a backport of the fix to version 1.

It would be possible to have e.g. PHPUnit 8 and PHPUnit 9, but that would only support >= 7.2 and as 7.2 is already unsupported, I think it can be dropped as well. If anyone want's to support version 1 and 2 in his project, there is always the possibility to have e.g. "^1.0|^2.0" in the composer version constraint.

@yetanotherape yetanotherape merged commit e93beb9 into yetanotherape:master Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants