-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to php 8.0 #18
Conversation
Hi Ernest! Thank you for your effort. I see that old PHP versions are still in use and I think it's better to add support of PHP 8 without dropping support for the old ones. |
We cannot run phpUnit tests then, as the phpUnit version that supports PHP
8 dropped support for php below 7.3 :)
We could tag this as a major version upgrade as it will have breaking
changes for older php versions.
…On 2020-12-10, Thu at 20:21, yetanotherape ***@***.***> wrote:
Hi Ernest! Thank you for your effort.
I see <https://blog.packagist.com/php-versions-stats-2020-1-edition/>
that old PHP versions are still in use and I think it's better to add
support of PHP 8 without dropping support for the old ones.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDWTAODWU7MWDXYVNBC5ZDSUEGRNANCNFSM4UVG7M4A>
.
|
Hmm... I'll try to read about this. Actually, I migrated to Python as a main language and don't follow PHP news 😄 |
No worries, when you have time... |
Well, I think all the older versions and hhvm can be dropped. Don't think that there is a big issue, if a new major version just supports >= 7.3. If there is really a fix to be made in the classes, there is always the possibility for a backport of the fix to version 1. It would be possible to have e.g. PHPUnit 8 and PHPUnit 9, but that would only support >= 7.2 and as 7.2 is already unsupported, I think it can be dropped as well. If anyone want's to support version 1 and 2 in his project, there is always the possibility to have e.g. "^1.0|^2.0" in the composer version constraint. |
# Conflicts: # .travis.yml # Dockerfile_7.3 # Dockerfile_8.0 # composer.json
Minimal changes, I've only added
er
to theMatch
class andmatch
variables.Also upadted phpUnit to the version that supports php 8.0, because of this had to drop support for older php versions.
I guess it's okay as older PHP versions are not supported anymore...