Bugfix in OctoAssociator.transform_events #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OctoAssociator.transform_events the events are transformed back from local to global EPSG:4326 coordinates. In that course a scaling of the local coordinates from kilometers to meters or kilometers takes place, which requires a multiplication with the scaling factor (1000 or 1) rather than a division. With this fix in place, correct event coordinates are now obtained also in EPSG:4326.
|
Thanks for the great catch! I've added a unit test and will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OctoAssociator.transform_events the events are transformed back from local to global EPSG:4326 coordinates. In that course a scaling of the local coordinates from kilometers to meters (or kilometers) takes place, which requires a multiplication with the scaling factor of 1000 (or 1) rather than a division.
With this fix in place, correct event coordinates are obtained also in EPSG:4326.