-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback constructor for FutureLink #1272
Callback constructor for FutureLink #1272
Conversation
I'll also update the documentation for |
@kellpossible these changes look solid to me! |
@kellpossible cool if I merge this? |
I never added an example, do you think it's okay? |
Yeah, that's fine with me |
It also lacks tests. But if its good to merge then go ahead. I also ran the tests I believe but didn't check the box because I hadn't made the example. |
Great, thanks @jstarry ! |
Description
This is an initial implementation, just requesting comments at this stage. I still need to implement some examples.
FutureLink::callback_future()
, and implement it forComponentLink
andAgentLink
.FutureLink::send_future()
to takeInto<Message>
instead ofMessage
to make it matchComponentLink::send_message()
more closely, and more convenient to use.Implements #1271
Checklist:
./ci/run_stable_checks.sh