Fix Travis builds #1459
Merged
Fix Travis builds #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well... That didn't seem to help either. |
turns out wasm-pack doesn't actually install the latest version. It has version 0.26 hardcoded
|
Turns out my initial assumptions were completely off:
TL;DR: Geckodriver version 0.27 currently doesn't seem to get along with wasm-bindgen. |
jstarry
pushed a commit
that referenced
this pull request
Aug 16, 2020
* remove manual geckodriver download * remove env variable * maybe 0.27 is broken?
teymour-aldridge
pushed a commit
to teymour-aldridge/yew
that referenced
this pull request
Sep 1, 2020
* remove manual geckodriver download * remove env variable * maybe 0.27 is broken?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wasm-pack can automatically download the latest Geckodriver so we don't need to do it manually. I forgot to include this in #1415 but now is a good time to do it because it should fix the builds.
See Also: rustwasm/wasm-bindgen#2261.