Run doc tests in CI on wasm target #2528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit 8a3c4e3): https://yew-rs--pr2528-wasm-doc-tests-e2r64ek0.web.app (expires Fri, 25 Mar 2022 16:04:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
voidpumpkin
reviewed
Mar 19, 2022
| @@ -18,7 +18,7 @@ wasm-bindgen-futures = "0.4" | |||
| weblog = "0.3.0" | |||
| yew = { path = "../../packages/yew/", features = ["ssr"] } | |||
| yew-router = { path = "../../packages/yew-router/" } | |||
| tokio = { version = "1.15.0", features = ["full"] } | |||
| #tokio = { version = "1.15.0", features = ["full"] } | |||
There was a problem hiding this comment.
Why is this commented out? Shouldn't it be used in this example? If its not used maybe just remove the line?
There was a problem hiding this comment.
Testing purposes. I was figuring out why CI is failing.
|
Closing this until trunk-rs/trunk#20 is a thing. Using wasm-bindgen-cli directly is very finicky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run doc tests in CI on wasm32-unknown-unknown target and on nightly toolchain
Fixes #2503
Limitations