-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm doc tests #2651
Merged
Merged
Wasm doc tests #2651
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8853660
don't use wasm-pack for wasm tests
ranile 6935acd
use proper version of wasm-bindgen-cli
ranile 264372b
also run with chrome driver
ranile fbff749
use cargo pkgid
ranile 99fc79c
wasm doc tests
ranile 2243278
setup web drivers
ranile aba95b6
temp workaround
ranile e14d49a
fix failures
ranile 4a1bf47
remove debug info
ranile f3e7cb0
don't be dumb
ranile c32ad82
specific ref for benchmark workflow so it doesn't fail
ranile 57004dc
Revert "specific ref for benchmark workflow so it doesn't fail"
ranile File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
[target.'cfg(target_arch = "wasm32")'] | ||
runner = 'wasm-bindgen-test-runner' | ||
|
||
[unstable] | ||
doctest-xcompile = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the best solution I have until rustwasm/wasm-bindgen#2881 is merged and published. I tried building wasm-bindgen-test-runner on my local computer and putting it in
ci
directory but it won't run because it's not built with musl and I can't get a musl build to work locally