Mitigate ordering dependency between Facets and SearchBar #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facet retrieval isn't enabled until the Facets component is mounted and initial search happens when the the SearchBar component is mounted, creating an ordering dependency between the two components, if one wishes for facets to be present for an initial search. The location permissions check in 4afecdd mitigates this issue by performing the search asynchronously; this commit makes the code path also asynchronous in browsers that don't support the permissions API.
Delerme
approved these changes
Dec 6, 2019
vramesh1
pushed a commit
that referenced
this pull request
Dec 14, 2019
Facet retrieval isn't enabled until the Facets component is mounted and initial search happens when the the SearchBar component is mounted, creating an ordering dependency between the two components, if one wishes for facets to be present for an initial search. The location permissions check in 4afecdd mitigates this issue by performing the search asynchronously; this commit makes the code path also asynchronous in browsers that don't support the permissions API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facet retrieval isn't enabled until the Facets component is mounted and
initial search happens when the the SearchBar component is mounted,
creating an ordering dependency between the two components, if one
wishes for facets to be present for an initial search.
The location permissions check in
4afecdd mitigates this issue by
performing the search asynchronously; this commit makes the code path
also asynchronous in browsers that don't support the permissions API.
Fixes #369