chore: add storybook #2

tatimblin · 2022-11-03T19:04:57Z

Setting up storybook with the vite-builder plugin

J=SLAP-2442
TEST=manual

checked-out address and ran without errors

.eslintrc.js

.storybook/main.js

package.json

yen-tt

I believe this item includes creating a Storybook Site that will be kept up-to-date with main branch. Can you add the necessary github actions for that as well?

tatimblin · 2022-11-04T14:44:51Z

I believe this item includes creating a Storybook Site that will be kept up-to-date with main branch. Can you add the necessary github actions for that as well?

@yen-tt I added the workflow to this. I'll add the ci config in that branch directly in a separate pr

tmeyer2115

As part of SLAP-2442, we'll want to add Yext-specific styling to the Storybook Site. This requires adding some things to the .storybook directory. You can see what we did to add the Yext branding/styling to the Search UI React Site here: yext/search-ui-react@e3d1259.

I think we should keep this PR as is. It's goal is to add Storybook to the repo. Then, you'll have a second PR (once the Address is merged in), creating Address Stories and the Yext branding.

package.json

.storybook/main.js

.github/workflows/sync_sites_branch.yml

.eslintrc.js

.prettierrc.json

.storybook/yextTheme.cjs

package.json

.eslintrc.js

J=SLAP-2442 TEST=manual checked-out address and ran without errors

…y notices check

.storybook/main.js

.storybook/preview-head.html

package.json

.github/workflows/run_linting.yml

nmanu1

looks like several tests are failing. I thought they should all (or almost all) be passing now?

tatimblin · 2022-11-15T13:44:38Z

@nmanu1 jest tests will also fail because there are currently no tests

nmanu1 · 2022-11-15T13:52:39Z

@nmanu1 jest tests will also fail because there are currently no tests

I thought a test was added for the Address component, which is now in main? Shouldn't at least the tests checks marked as (pull_request) pass? Also, looks like Percy is failing. Is this PR supposed to set up those snapshots now that we have Storybook, or will that be a different item/PR?

tatimblin · 2022-11-15T13:56:58Z

@nmanu1 jest tests will also fail because there are currently no tests

I thought a test was added for the Address component, which is now in main? Shouldn't at least the tests checks marked as (pull_request) pass? Also, looks like Percy is failing. Is this PR supposed to set up those snapshots now that we have Storybook, or will that be a different item/PR?

The checks say no tests were found. Percy fails because there are no stories yet, I will add address stories in a separate PR after Storybook is merged

nmanu1 · 2022-11-15T14:06:05Z

package.json

    ],
    "moduleDirectories": [
      "node_modules",
      "<rootDir>"
    ],
-    "testEnvironment": "jsdom",


why is this no longer needed?

it was specified on the other branch

not sure I follow. it looks like all other branches/changes have been merged into main. so, won't this delete the line from main?

this is the same concern I had for the test file that's being deleted too

@nmanu1 I added it back

ok! so the tests checks should pass now, right?

actually it looks like there's an error because of the file extensions in the Jest config

.storybook/preview.js

.npmrc

tests/components/Address.test.tsx

nmanu1 · 2022-11-15T20:25:03Z

package.json

@@ -56,10 +83,11 @@
    ],
    "transform": {
      "\\.[jt]sx?$": "ts-jest"
+    },
+    "globals": {
+      "ts-jest": {


looks like specifying the ts-jest config under globals is deprecated and should be moved according to here

yes just fixed that. ready now

tatimblin requested a review from a team as a code owner November 3, 2022 19:04

yen-tt reviewed Nov 3, 2022

View reviewed changes

.eslintrc.js Outdated Show resolved Hide resolved

.storybook/main.js Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

yen-tt reviewed Nov 3, 2022

View reviewed changes

tatimblin mentioned this pull request Nov 4, 2022

feat(address): add component #1

Merged

tmeyer2115 reviewed Nov 7, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

.storybook/main.js Outdated Show resolved Hide resolved

nmanu1 reviewed Nov 7, 2022

View reviewed changes

.github/workflows/sync_sites_branch.yml Show resolved Hide resolved

nmanu1 reviewed Nov 7, 2022

View reviewed changes

.eslintrc.js Outdated Show resolved Hide resolved

tatimblin changed the title ~~chore: add storybook 7~~ chore: add storybook Nov 8, 2022

nmanu1 reviewed Nov 8, 2022

View reviewed changes

.prettierrc.json Outdated Show resolved Hide resolved

.storybook/yextTheme.cjs Show resolved Hide resolved

.storybook/yextTheme.cjs Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

.eslintrc.js Outdated Show resolved Hide resolved

tatimblin added 7 commits November 8, 2022 16:15

chore: add storybook 7

9465ef8

J=SLAP-2442 TEST=manual checked-out address and ran without errors

chore: resolve merge conflict

dfcb7df

add workflow to sync branch

d3e43fb

update eslint

90b896d

remove mdx stories filter

1c327b4

add branding

d732e2a

setup and run prettier

a0414fb

tatimblin force-pushed the dev/storybook branch from 7c5a07e to a0414fb Compare November 8, 2022 22:23

Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…

d7d9de2

…y notices check

tmeyer2115 reviewed Nov 9, 2022

View reviewed changes

.storybook/main.js Outdated Show resolved Hide resolved

.storybook/preview-head.html Outdated Show resolved Hide resolved

pr comments

d65f364

nmanu1 reviewed Nov 10, 2022

View reviewed changes

package.json Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

update packages

01e3851

nmanu1 reviewed Nov 10, 2022

View reviewed changes

.github/workflows/run_linting.yml Outdated Show resolved Hide resolved

add lint_script

e5b9ff6

nmanu1 reviewed Nov 14, 2022

View reviewed changes

tatimblin added 3 commits November 14, 2022 16:13

update transitive dependencies

841edec

prettier

0e29da5

add eslint plugin

62069c0

tatimblin force-pushed the dev/storybook branch from ba8f06e to 62069c0 Compare November 15, 2022 13:44

nmanu1 reviewed Nov 15, 2022

View reviewed changes

tatimblin added 4 commits November 15, 2022 09:26

add jsdom

072b351

re-add address test

a72824a

lint

fddd1ff

moduleFileExtensions

fbc243e

nmanu1 reviewed Nov 15, 2022

View reviewed changes

downgrade testing-library

237495e

tmeyer2115 self-requested a review November 16, 2022 13:52

tmeyer2115 approved these changes Nov 16, 2022

View reviewed changes

tatimblin merged commit 8806172 into main Nov 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add storybook #2

chore: add storybook #2

tatimblin commented Nov 3, 2022 •

edited

Loading

yen-tt left a comment •

edited

Loading

tatimblin commented Nov 4, 2022

tmeyer2115 left a comment

nmanu1 left a comment

tatimblin commented Nov 15, 2022

nmanu1 commented Nov 15, 2022

tatimblin commented Nov 15, 2022

nmanu1 Nov 15, 2022

tatimblin Nov 15, 2022

nmanu1 Nov 15, 2022

nmanu1 Nov 15, 2022

tatimblin Nov 15, 2022

nmanu1 Nov 15, 2022

nmanu1 Nov 15, 2022

nmanu1 Nov 15, 2022

tatimblin Nov 15, 2022

chore: add storybook #2

chore: add storybook #2

Conversation

tatimblin commented Nov 3, 2022 • edited Loading

yen-tt left a comment • edited Loading

Choose a reason for hiding this comment

tatimblin commented Nov 4, 2022

tmeyer2115 left a comment

Choose a reason for hiding this comment

nmanu1 left a comment

Choose a reason for hiding this comment

tatimblin commented Nov 15, 2022

nmanu1 commented Nov 15, 2022

tatimblin commented Nov 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tatimblin commented Nov 3, 2022 •

edited

Loading

yen-tt left a comment •

edited

Loading