[pull] main from thanos-io:main #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Receiver: cache matchers for series calls We have tried caching matchers before with a time-based expiration cache, this time we are trying with LRU cache. We saw some of our receivers busy with compiling regexes and with high CPU usage, similar to the profile of the benchmark I added here: * Adding matcher cache for method `MatchersToPromMatchers` and a new version which uses the cache. * The main change is in `matchesExternalLabels` function which now receives a cache instance. adding matcher cache and refactor matchers Co-authored-by: Andre Branchizio <[email protected]> Signed-off-by: Pedro Tanaka <[email protected]> Using the cache in proxy and tsdb stores (only receiver) Signed-off-by: Pedro Tanaka <[email protected]> fixing problem with deep equality Signed-off-by: Pedro Tanaka <[email protected]> adding some docs Signed-off-by: Pedro Tanaka <[email protected]> Adding benchmark Signed-off-by: Pedro Tanaka <[email protected]> undo unecessary changes Signed-off-by: Pedro Tanaka <[email protected]> Adjusting metric names Signed-off-by: Pedro Tanaka <[email protected]> adding changelog Signed-off-by: Pedro Tanaka <[email protected]> wiring changes to the receiver Signed-off-by: Pedro Tanaka <[email protected]> Fixing linting Signed-off-by: Pedro Tanaka <[email protected]> docs Signed-off-by: Pedro Tanaka <[email protected]> * using singleflight to get or set items Signed-off-by: Pedro Tanaka <[email protected]> * improve metrics Signed-off-by: Pedro Tanaka <[email protected]> * Introduce interface for matchers cache Signed-off-by: Pedro Tanaka <[email protected]> * fixing unit test Signed-off-by: Pedro Tanaka <[email protected]> * adding changelog Signed-off-by: Pedro Tanaka <[email protected]> * fixing benchmark Signed-off-by: Pedro Tanaka <[email protected]> * moving matcher cache to storecache package Signed-off-by: Pedro Tanaka <[email protected]> * Trying to make the cache more reusable introducing interface Signed-off-by: Pedro Tanaka <[email protected]> Fixing problem with wrong initialization Signed-off-by: Pedro Tanaka <[email protected]> Moving interface to storecache package Signed-off-by: Pedro Tanaka <[email protected]> remove empty file and fix calls to constructor passing nil; Signed-off-by: Pedro Tanaka <[email protected]> * Fix false entry on change log Signed-off-by: Pedro Tanaka <[email protected]> * Removing default value for registry and rename test file Signed-off-by: Pedro Tanaka <[email protected]> * Using fmt.Errf() Signed-off-by: Pedro Tanaka <[email protected]> * Remove method that is not on interface anymore Signed-off-by: Pedro Tanaka <[email protected]> * Remove duplicate get call Signed-off-by: Pedro Tanaka <[email protected]> --------- Signed-off-by: Pedro Tanaka <[email protected]> Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Roberto O. Fernández Crisial <[email protected]> Signed-off-by: Roberto O. Fernández Crisial <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )