Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows (CMake): less verbose output when compiling #182

Closed
DavidVujic opened this issue Jul 5, 2019 · 4 comments
Closed

Windows (CMake): less verbose output when compiling #182

DavidVujic opened this issue Jul 5, 2019 · 4 comments
Assignees

Comments

@DavidVujic
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The output is too verbose when running npm install to start the build process. Especially the output from the ./configure command creates a lot of log rows in the console.

Describe the solution you'd like
Add these flags to the ./configure command (in the scripts/build.js file):

--enable-silent-rules --quiet

This will shorten the output on Mac OS and Linux machines. On Windows there should be possible to shorten the CMake output too, a feature to investigate!

@jbienkowski311
Copy link
Contributor

For configure script we definitely need --enable-silent-rules --quiet flags. For make command we could use either make > /dev/null or --no-print-directory --quiet flags. I will boot into Windows and investigate CMake flags.
Providing additional flag to npm install could reveal suppressed output - it would be very useful during the development process. For example something like ZK_BUILD_VERBOSE=1 npm install.

@jbienkowski311
Copy link
Contributor

I have experimented with build on Windows, but with no great success. I did not find any useful CMake flags, but to be completely honest I do not think we need to worry about it. node_zookeeper supports Windows only for development, and as I stated before, for development we should leave the build output "as is".
If someone wants to debug it further, I will be more than glad to help.

@DavidVujic DavidVujic changed the title Less verbose output when compiling Windows (CMake): less verbose output when compiling Jul 6, 2019
@DavidVujic
Copy link
Collaborator Author

DavidVujic commented Jul 6, 2019

I'll leave this issue open, for further investigation if there is possible to do something with the verbose output in Windows.

@DavidVujic DavidVujic added the Windows Issues specific for the Windows platform label Jul 11, 2019
@DavidVujic
Copy link
Collaborator Author

@DavidVujic DavidVujic self-assigned this Jul 22, 2019
@DavidVujic DavidVujic mentioned this issue Jul 23, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants