Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will enable a quicker build experience for Windows users. It will bypass CMake feature checks and will also hide compiler warnings in the output, by overwriting the default
CMakeLists.txt
.There is an option to still use the default, by passing in the
ZK_INSTALL_VERBOSE
flag as described here.Motivation and Context
To improve the developer experience on the Windows platform.
Fixes issue #182
How Has This Been Tested?
Travis CI build passed (Windows, Linux, Mac OS X)
Manual
npm install
in a Windows 10 virtual machine.Types of changes
Checklist: