Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less verbose Windows builds #217

Merged
merged 1 commit into from
Aug 18, 2019

Conversation

DavidVujic
Copy link
Collaborator

Description

By default, building on Windows will be less verbose. There's still a couple of warnings there, and should be fixed in a separate PR.

Motivation and Context

To increase the developer experience on Windows.

How Has This Been Tested?

Travis CI Build OK
Ran npm install on a Windows 10 VM manually (both with and without the verbose flag set).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic
Copy link
Collaborator Author

I'll just go ahead and merge this one.

@DavidVujic DavidVujic merged commit 933e9b4 into yfinkelstein:master Aug 18, 2019
@DavidVujic DavidVujic deleted the quiet_windows branch August 18, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant