Zookeeper 3.5.6 and rollback for Windows client (3.4.14) #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is aiming to solve issues for Windows clients.
Mac OS X and Linux will use ZooKeeper 3.5.6 - the current latest stable version. Windows clients will use version 3.4.14, because of compatibility issues between client and server as described in issue #222. I think this could be an issue in the C client and will investigate it in a separate issue.
To be able to support two Minor versions of ZooKeeper, the logger in the C++ Wrapper
node-zk.cpp
had to be rewritten. The logger API is different between the versions.Also, Node.js 8 has been removed from the Travis CI build. I think supporting the two latest LTS versions of Node.js is good enough.
Got feedback?
Motivation and Context
Fixes issue #222
How Has This Been Tested?
Travis CI build OK
Docker integration tests, examples, GCC and unit tests passed.
Types of changes
Checklist: