Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zookeeper 3.5.6 and rollback for Windows client (3.4.14) #226

Merged
merged 12 commits into from
Nov 5, 2019

Conversation

DavidVujic
Copy link
Collaborator

@DavidVujic DavidVujic commented Nov 2, 2019

Description

This PR is aiming to solve issues for Windows clients.

Mac OS X and Linux will use ZooKeeper 3.5.6 - the current latest stable version. Windows clients will use version 3.4.14, because of compatibility issues between client and server as described in issue #222. I think this could be an issue in the C client and will investigate it in a separate issue.

To be able to support two Minor versions of ZooKeeper, the logger in the C++ Wrapper node-zk.cpp had to be rewritten. The logger API is different between the versions.

Also, Node.js 8 has been removed from the Travis CI build. I think supporting the two latest LTS versions of Node.js is good enough.

Got feedback?

Motivation and Context

Fixes issue #222

How Has This Been Tested?

Travis CI build OK
Docker integration tests, examples, GCC and unit tests passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic changed the title WIP: Zookeeper 3.5.6 and rollback for Windows client (3.4.14) Zookeeper 3.5.6 and rollback for Windows client (3.4.14) Nov 3, 2019
@DavidVujic DavidVujic merged commit b53615c into yfinkelstein:master Nov 5, 2019
@DavidVujic DavidVujic deleted the zookeeper_3_5_6 branch November 5, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant