Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster install process with prebuilt binaries #251

Merged
merged 4 commits into from
Nov 29, 2020

Conversation

DavidVujic
Copy link
Collaborator

Fixes #250

Description

The source code will include prebuilt binaries for Mac OS X (darwin, x64) and Windows - for node 12 and 14. This will simplify and fasten the install process a lot.

Especially for Windows users that no longer will need to have CMake or C++ build tools installed. For Mac OS X users, the install process will be much faster.

In short: npm install will not trigger a Native AddOn build, because the binaries are already there. However, builds will still be run for systems that does not match the binaries.

How Has This Been Tested?

  • Travis CI build OK
  • Mac OS X: installed the library - verified there was not builds - and ran an example project connecting to a ZooKeeper server (hosted in docker).
  • Windows 10: installed the library - verified there was not builds - and ran an example project connecting to a ZooKeeper server (hosted at the local machine). A virtual Windows machine running in Azure.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic
Copy link
Collaborator Author

The package will be heavier, but I think it is worth it.

Also, I am thinking about dropping Node 12 prebuilds during 2021.

@DavidVujic DavidVujic merged commit 1a7b82a into yfinkelstein:master Nov 29, 2020
@DavidVujic DavidVujic deleted the use-prebuildify branch November 29, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Prebuildify
2 participants