Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameters in ApplicationRunner methods runBootstrap() and checkEvents() #37

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 12, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (0e33a2e) compared to base (53ee5aa).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 0e33a2e differs from pull request most recent head 508dd70. Consider uploading reports for the commit 508dd70 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #37   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        26        26           
===========================================
  Files              3         3           
  Lines             81        81           
===========================================
  Hits              81        81           
Impacted Files Coverage Δ
src/ApplicationRunner.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark samdark merged commit 2ebd731 into master Jan 12, 2023
@samdark samdark deleted the improve branch January 12, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants