Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Yii config group names convention #39

Merged
merged 17 commits into from
Feb 19, 2023
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 19, 2023

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 98.87% // Head: 98.57% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (87e8ca5) compared to base (dae4ba0).
Patch coverage: 97.67% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     98.87%   98.57%   -0.31%     
+ Complexity       27       23       -4     
============================================
  Files             3        2       -1     
  Lines            89       70      -19     
============================================
- Hits             88       69      -19     
  Misses            1        1              
Impacted Files Coverage Δ
src/ApplicationRunner.php 98.27% <97.22%> (-1.73%) ⬇️
src/BootstrapRunner.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README should be updated.

src/ApplicationRunner.php Outdated Show resolved Hide resolved
src/ApplicationRunner.php Show resolved Hide resolved
src/ApplicationRunner.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/ApplicationRunner.php Show resolved Hide resolved
src/ApplicationRunner.php Show resolved Hide resolved
src/ApplicationRunner.php Show resolved Hide resolved
@vjik vjik requested a review from a team February 1, 2023 13:09
@vjik vjik added the status:code review The pull request needs review. label Feb 1, 2023
@vjik vjik merged commit d6dea18 into master Feb 19, 2023
@vjik vjik deleted the adapt-to-yii-convention branch February 19, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants