Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom config modifiers #54

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 22, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #45

@vjik vjik added the status:code review The pull request needs review. label Nov 22, 2023
@vjik vjik requested a review from a team November 22, 2023 17:09
Copy link

what-the-diff bot commented Nov 22, 2023

PR Summary

  • Version Update

    • The version number has been updated to 2.1.0 for better tracking of build and release cycles.
  • Enhanced Customization Capability

    • Added a new feature that allows users to set their own configuration modifiers, enhancing the flexibility of the system. Affected files include src/ApplicationRunner.php, tests/ApplicationRunnerTest.php, tests/Support/ApplicationRunner/ApplicationRunner.php.
  • Testing Capability Extended

    • Extended the test suite with a new method named testConfigModifiers(). This will verify the proper functioning of the newly added ability to set custom config modifiers.
  • Addition of Custom Configuration Files

    • Added two new files ('custom.php' and 'custom2.php') within a group named 'custom'. These files provide the capability for users to customize their configurations for the system.
  • Addition to Changelog

    • In the 'CHANGELOG.md' file, an item about the new ability to set custom config modifiers has been added. This records our changes and enhancements for tracking purposes.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (268f7b8) 100.00% compared to head (f968e6d) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #54   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        23        23           
===========================================
  Files              2         2           
  Lines             70        71    +1     
===========================================
+ Hits              70        71    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit fd7929b into master Nov 22, 2023
31 checks passed
@samdark samdark deleted the custom-modifiers branch November 22, 2023 19:59
@samdark
Copy link
Member

samdark commented Nov 22, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants