Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom config merge plan file path, config and vendor directories #58

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 7, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

what-the-diff bot commented Mar 7, 2024

PR Summary

  • Enhancement in Configuration Customization
    The team has made updates to allow for setting a custom config merge plan file path, and specifying config and vendor directories in the Application Runner. This allows a much deeper level of configuration customization.

  • Test Addition for Configuration
    Tests have been added for the config merge plan file and config directory in the Application Runner Test file. This ensures the newly introduced feature works as expected.

  • New Properties Introduced in Application Runner
    The Application Runner now has configDirectory and vendorDirectory. This gives additional control in specifying locations of config files which is helpful for maintaining organized codebases.

  • New Files in the Custom Config Directory
    Files named test-merge-plan.php, .merge-plan.php, and params.php have been added to the custom-config directory in the test space. These new files will further enable testing and validation of the application running phase.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (924f7c9) to head (f5ef1e0).

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #58   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        23        23           
===========================================
  Files              2         2           
  Lines             71        72    +1     
===========================================
+ Hits              71        72    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik linked an issue Mar 7, 2024 that may be closed by this pull request
@vjik vjik requested a review from a team March 7, 2024 07:14
@vjik vjik added the status:code review The pull request needs review. label Mar 7, 2024
@vjik vjik merged commit f84108c into master Mar 7, 2024
32 checks passed
@vjik vjik deleted the more-settings branch March 7, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to customize paths to vendor and config directories
2 participants