This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Rate limiter implementation(gcra) #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge base repository
Update fork
Update fork
update fork
update fork
kamarton
reviewed
Jan 11, 2020
|
It would be great if the logic was ported from Yii2 |
|
@rustamwin GCRA is better about resource consumption than Yii 2 leaky bucket. |
|
GCRA is good for transactional system, but simple atomic counter design is low cost operation.
|
kamarton
reviewed
Jan 11, 2020
kamarton
suggested changes
Jan 11, 2020
kamarton
reviewed
Jan 11, 2020
kamarton
reviewed
Jan 11, 2020
xepozz
reviewed
Jan 14, 2020
xepozz
reviewed
Jan 14, 2020
|
Another test is planned to ensure that distribution of increments is OK after reaching the limit. @romkatsu is on it. |
kamarton
reviewed
Jan 14, 2020
kamarton
reviewed
Jan 14, 2020
kamarton
reviewed
Jan 14, 2020
kamarton
reviewed
Jan 15, 2020
xepozz
suggested changes
Jan 15, 2020
kamarton
suggested changes
Jan 16, 2020
|
Thank you very much, @romkatsu for implementing it and everyone else for reviews. |
samdark
added
type:feature
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
Co-authored-by: Alexander Makarov <[email protected]>
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
Co-authored-by: Alexander Makarov <[email protected]>
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
Co-authored-by: Alexander Makarov <[email protected]>
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
Co-authored-by: Alexander Makarov <[email protected]>
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
Co-authored-by: Alexander Makarov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous pull request #203
GCRA
https://brandur.org/rate-limiting
https://blog.ian.stapletoncordas.co/2018/12/understanding-generic-cell-rate-limiting.html