Implement bootstrap extension #20

qiangxue · 2013-03-25T03:10:43Z

The extension contains a set of widgets implementing various features provided by Twitter Bootstrap.

allanfreitas · 2013-03-25T03:33:59Z

@qiangxue @samdark I think the ideia of "yiiext.github.com" it's awesome, with "official" extensions, and not include many things on the CORE of Yii. The actual version (1.1.13) is already about 19Mb of size, when decompressed.
What do you think about? (it's only my opinion, I want to know yours).

qiangxue · 2013-03-25T03:41:09Z

First, this is an extension, meaning optional in downloading. So you shouldn't worry about download size.
Second, we want to officially maintain some commonly used extensions so that developers can have ready-to-use and high-quality tools they need without the worry of code breaks or discontinued support.

allanfreitas · 2013-03-25T03:59:08Z

@qiangxue Thanks for explain it. It's good to know that will exist official extensions, this three qualities (ready-to-use|high-quality|continued support) on Yii tools are awesome features.

schmunk42 · 2013-03-25T09:43:38Z

Will you separate this extension into an own repository?

samdark · 2013-03-25T10:01:40Z

Not this one, I guess.

schmunk42 · 2013-03-25T10:12:25Z

Please consider it, we also had this discussion about the zii widgets, it's minimal overhead to include it as a package, but would greatly enhance the modularity of the framework.

E.g. if someone wouldn't use bootstrap at all he would not require this package and get a slimmer core. This applies also to any package which depends on other code, eg. zii-widgets depend on jQuery.

tonydspaniard · 2013-03-25T10:38:05Z

@qiangxue @samdark "officially maintain some commonly used extensions so that developers can have ready-to-use and high-quality tools they need without the worry of code breaks or discontinued support"

Bootstrap is an external source, what would happen if bootstrap is in the future replaced in use by, for example, the zurb foundation? I do not think that it should be officially supported but Yii should provide the right standards to avoid the creation of bad and buggy extensions and let developers do the rest.

samdark · 2013-03-25T10:43:16Z

@tonydspaniard we'll support one of these bootstrapping frameworks. Most probably it will be Twitter's since Foundation dropped support of IEs except the very latest too soon.

schmunk42 · 2013-03-25T11:33:08Z

Yii2 should provide support for any CSS/UI framework and no framework or components should be tied to the core.

samdark · 2013-03-25T11:43:30Z

It will not be tied. It will be bundled.

tonydspaniard · 2013-05-05T05:29:49Z

Chris and I have nearly finished Yiistrap and Yiiwheels. We joined forces to improve its last library and also to stand up over YiiBooster, library that I no longer support, adding Yiiwheels to extend Yiistrap so to keep one and only library from Twitter Bootstrap's.

@samdark @qiangxue maybe would you consider adding both as one library to Yii2?

qiangxue · 2013-05-05T13:56:35Z

@tonydspaniard We can certainly consider adding them to Yii 2, provided that you are willing to modify the license terms to follow that of the existing Yii 2 code. Having said that, I think if we decide to move along this way, we need to agree on the design of the base classes first, and then modify the more concrete class implementations. Actually it will be almost like a rewrite. The main difference is that you have much more experience with these bootstrap widgets and probably have better idea than us on how to make them even better. Do you think this is fine with you? We may discuss further details in emails.

tonydspaniard · 2013-05-05T15:01:59Z

@qiangxue I would love to participate actively with them. My only concern is that I worked with Chris and what we did is a rewrite of his Yii-bootstrap and he asked me to keep the copyright. Nevertheless, Yiistrap is a library built for Yii 1.1.+ and I do not see any issue in building a new that will comply with Yii2 expectations.

I will ask Chris, as my ethics force me to do so, if he wishes to work with me in order to integrate Yiistrap + Yiiwheels into Yii2. Whatever his answer is, please count me in.

crisu83 · 2013-05-06T08:06:46Z

Hello, I'm joining in a bit late but I just wanted to say that I'm open for discussion about developing similar functionality as Yiistrap for Yii2. I would love to participate.

* upstream: Fixes issue yiisoft#320: Module::createController() will fail with a route with trailing slash. Fixed test break about AssetController. requirements css.php twitter bootstrap update to 2.3.2 Twitter bootstrap updated to 2.3.2 Modified the IAssetConvert interface. hashing the key for registerCss and registerJs. Update AccessRule.php refactored code after feedback Fixed framework path. Added support for View::POS_READY. new proposed structure remove from master (update track) made some changes, fix some pitfalls, remove PHP_EOL yiisoft#20 proposed architecture for bootstrap Conflicts: yii/helpers/base/Inflector.php

marsuboss · 2013-06-06T09:02:37Z

You use what version of Bootstrap ? v2.x or v3.x ?

schmunk42 · 2013-06-06T09:12:34Z

Shouldn't the bootstrap code go into https://github.com/yiisoft/yii2/tree/master/extensions? Same with jui.
Otherwise it's in the core and it will be harder for developers the develop with other CSS frameworks.

samdark · 2013-06-06T09:25:19Z

I think it should.

qiangxue · 2013-06-06T10:00:15Z

What's the drawback of keeping bootstrap in the core?

samdark · 2013-06-06T10:06:00Z

There are no drawbacks keeping it as official extension.

qiangxue · 2013-06-06T10:07:27Z

There is:

The debug toolbar (will be in the core) will use bootstrap;
It's possible some future core modules will depend on bootstrap.

samdark · 2013-06-06T10:09:59Z

What if you prefer foundation? Both bootstrap and foundation will be loaded at the same time?
Gii?

qiangxue · 2013-06-06T10:15:21Z

What if you prefer foundation? Both bootstrap and foundation will be loaded at the same time?

Nope. The debug toolbar itself won't use any CSS framework. It is the debug module that will display standalone debug pages which will use bootstrap.

Gii could be in either core or official extension. If it will be in the core, then that's another positive argument.

Basically my argument is that if we have some core code that depends on a CSS framework to work well, then we should keep this CSS framework in the core.

samdark · 2013-06-06T10:17:33Z

It's OK for me to keep bootstrap in the core as long as it's used for standalone modules only i.e. not conflicting with any user JS/CSS.

As for jui, I think it worth moving into separate official package.

qiangxue · 2013-06-06T10:22:12Z

I agree moving jui to extensions. We only need one such framework to use for GUI-related core code (with the assumption that it won't interfere with application code).

Regarding core vs. official extensions: the only advantage of using official extensions is that it makes the size of the core code smaller. Our situation is different from ZF2/SF2 since our extensions are not designed to be reused in other frameworks.

schmunk42 · 2013-06-06T10:23:25Z

The debug toolbar (will be in the core) will use bootstrap;

In the toolbar composer.json: require: { "yiisoft/yii2-bootstrap": "1.x"}

It's possible some future core modules will depend on bootstrap.

Then they should be also released as separate extensions and require yii2-bootstrap.

That would be much cleaner, IMHO. And if you want to release a complete archive the build process should take care of this.

qiangxue · 2013-06-06T10:42:49Z

Why should we turn the debug toolbar into an extension? This will be used by almost all applications. Turning it into an extension means extra dependency for every application, and the only benefit is that it makes the size of the core code smaller.

samdark · 2013-06-06T10:58:13Z

No need to decouple toolbar. It will be used in 99% developer's environments, I think.

Ragazzo · 2013-07-28T10:08:42Z

@creocoder is right definitely must be extension and not in the core.

crisu83 · 2013-07-28T10:10:17Z

I'm actually starting to lean towards moving it to the official extensions. I haven't looked that much as Yii2 yet so I'm still getting to know the whole structure.

samdark · 2013-08-02T13:32:13Z

@tonydspaniard what's left on this one except the decision to move it to an extension or not?

doliver3 · 2013-10-22T04:59:31Z

Could support for Bootstrap 3 be added?
Bootstrap 3 has been officially released for 2 months now.

cebe · 2013-10-22T07:44:15Z

@doliver3 we have bootstrap 3 already ;)

sensorario · 2013-10-22T10:59:52Z

<3

2013/10/22 Carsten Brandt [email protected]

@doliver3 https://github.com/doliver3 we have bootstrap 3 already ;)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-26783002
.

samdark · 2013-11-24T22:30:48Z

Bootstrap support implemented.

caching-http.md translated. [skip ci]

add runtime-logging.md

ghost assigned tonydspaniard May 9, 2013

tonydspaniard added a commit to tonydspaniard/yii2 that referenced this issue May 12, 2013

yiisoft#20 proposed architecture for bootstrap

6493f7a

Ragazzo mentioned this issue Jul 30, 2013

Implement bootstrap 3.0 #685

Closed

samdark closed this as completed Nov 24, 2013

asofter mentioned this issue Jan 2, 2014

Advanced template issue #1742

Closed

NPreston mentioned this issue Jun 4, 2014

Create migrate failed #3700

Closed

qiansen1386 pushed a commit to qiansen1386/yii2 that referenced this issue Jul 25, 2014

Merge pull request yiisoft#20 from AbrahamGreyson/master

73bb5c7

caching-http.md translated. [skip ci]

stepanselyuk mentioned this issue Sep 23, 2014

Problem with cacheSchema component: infinite loop #5106

Closed

mattdalmau mentioned this issue Jan 15, 2015

Using defaults in URLManager #6871

Closed

wangjun083 pushed a commit to wangjun083/yii2 that referenced this issue Oct 24, 2015

Merge pull request yiisoft#20 from zhoujiafei/master

2e87a59

add runtime-logging.md

buuug7 mentioned this issue Dec 2, 2015

a big bug in yii2 migrate #10301

Closed

ghost mentioned this issue Dec 15, 2015

Impossible to extend Signup validation rules #10392

Closed

ahmadfauzirahman99 mentioned this issue Apr 23, 2017

Big problem with migrate function #2355

Closed

buchenko mentioned this issue Jan 2, 2018

error in \yii\console\controllers\HelpController::getModuleCommands() #15446

Open

alexjohnp mentioned this issue Jan 30, 2018

Yii2 call to a member function getDB() on null after update to the latest version #15578

Closed

fmartiner mentioned this issue Feb 26, 2018

Controller id is null in model #15725

Closed

rezvania mentioned this issue Mar 11, 2018

independent db for an module #15874

Closed

Discomania mentioned this issue May 25, 2019

Invalid argument supplied for foreach() since version 2.0.16 #17326

Closed

SSiwek mentioned this issue Jul 19, 2019

Getting Oracle ora-00918 column ambiguously defined #17448

Closed

webceoboy mentioned this issue Nov 21, 2019

can not enable DbSession #17677

Closed

Geowan mentioned this issue Nov 22, 2019

Catching database connection errors fails #17682

Closed

error-500 mentioned this issue Nov 17, 2020

getRuntimePath() in HTMLPurifier #18392

Closed

hsegura mentioned this issue Mar 17, 2022

PHP 8.1 preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated #19310

Closed

Biggy905 mentioned this issue Feb 25, 2023

Permissions mode = 509. #19775

Closed

tahir-56ali mentioned this issue Aug 8, 2024

PHP Deprecated htmlspecialchars(): Passing null to parameter #19122

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement bootstrap extension #20

Implement bootstrap extension #20

qiangxue commented Mar 25, 2013

allanfreitas commented Mar 25, 2013

qiangxue commented Mar 25, 2013

allanfreitas commented Mar 25, 2013

schmunk42 commented Mar 25, 2013

samdark commented Mar 25, 2013

schmunk42 commented Mar 25, 2013

tonydspaniard commented Mar 25, 2013

samdark commented Mar 25, 2013

schmunk42 commented Mar 25, 2013

samdark commented Mar 25, 2013

tonydspaniard commented May 5, 2013

qiangxue commented May 5, 2013

tonydspaniard commented May 5, 2013

crisu83 commented May 6, 2013

marsuboss commented Jun 6, 2013

schmunk42 commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

schmunk42 commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

Ragazzo commented Jul 28, 2013

crisu83 commented Jul 28, 2013

samdark commented Aug 2, 2013

doliver3 commented Oct 22, 2013

cebe commented Oct 22, 2013

sensorario commented Oct 22, 2013

samdark commented Nov 24, 2013

Implement bootstrap extension #20

Implement bootstrap extension #20

Comments

qiangxue commented Mar 25, 2013

allanfreitas commented Mar 25, 2013

qiangxue commented Mar 25, 2013

allanfreitas commented Mar 25, 2013

schmunk42 commented Mar 25, 2013

samdark commented Mar 25, 2013

schmunk42 commented Mar 25, 2013

tonydspaniard commented Mar 25, 2013

samdark commented Mar 25, 2013

schmunk42 commented Mar 25, 2013

samdark commented Mar 25, 2013

tonydspaniard commented May 5, 2013

qiangxue commented May 5, 2013

tonydspaniard commented May 5, 2013

crisu83 commented May 6, 2013

marsuboss commented Jun 6, 2013

schmunk42 commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

qiangxue commented Jun 6, 2013

schmunk42 commented Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark commented Jun 6, 2013

Ragazzo commented Jul 28, 2013

crisu83 commented Jul 28, 2013

samdark commented Aug 2, 2013

doliver3 commented Oct 22, 2013

cebe commented Oct 22, 2013

sensorario commented Oct 22, 2013

samdark commented Nov 24, 2013