Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9438: yii\web\DbSession now relies on error handler to display errors #14908

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Fixes #9438: yii\web\DbSession now relies on error handler to display errors #14908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd85fa4
Fixes #9438: yii\web\DbSession now relies on error handler to display…
samdark Oct 3, 2017
d04e0fb
Merge branch 'master' into fix-php7-session-error-handling
samdark Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions framework/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Yii Framework 2 Change Log
2.0.13 under development
------------------------

- Enh #9438: `yii\web\DbSession` now relies on error handler to display errors (samdark)
- Bug #14129: Fixed console help to properly work with tricky camelcased controller names (samdark, silverfire)
- Enh #14126: Added variadic parameters support to DI container (SamMousa)
- Enh #14087: Added `yii\web\View::registerCsrfMetaTags()` method that registers CSRF tags dynamically ensuring that caching doesn't interfere (RobinKamps)
Expand Down
8 changes: 1 addition & 7 deletions framework/web/DbSession.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,7 @@ public function writeSession($id, $data)
->execute();
}
} catch (\Exception $e) {
$exception = ErrorHandler::convertExceptionToString($e);
// its too late to use Yii logging here
error_log($exception);
if (YII_DEBUG) {
echo $exception;
}

Yii::$app->errorHandler->handleException($e);
return false;
}

Expand Down