Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip shadow if window is maximized or tiled #7

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

velitasali
Copy link
Contributor

@velitasali velitasali commented Aug 3, 2022

Hi,

I don't think the extension needs to expose a setting for this.

Let me know what you think!

Closes #6.

@yilozt
Copy link
Owner

yilozt commented Aug 3, 2022

Hi @velitasali , change style of shadow is a good way, thanks for great works. Confirmed that shadow has been skipped when window are tiled / maximized.

There are still a small problem, because the shadow has been clear before set style, it will occurse flash when change shadow of windows.

Peek.2022-08-03.22-02.mp4

A solution is just clear style when window is tiled / maxmized, instead of clear it then apply again.

@yilozt
Copy link
Owner

yilozt commented Aug 3, 2022

I will fix this problem later, thanks for contribution.

@yilozt yilozt merged commit 59b903b into yilozt:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The shadow is still applied after the window is maximized
2 participants