Update Training Guidelines #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aca-2 * 'main' of https://github.com/iMountTai/Chinese-LLaMA-Alpaca-2: Update README_EN.md Update README.md Update README.md
airaria
previously approved these changes
Aug 17, 2023
airaria
reviewed
Aug 20, 2023
| --lora_dropout ${lora_dropout} \ | ||
| --torch_dtype float16 \ | ||
| --validation_file ${validation_file} \ | ||
| --peft_path ${peft_model} \ |
There was a problem hiding this comment.
Please explain more on the modifications?
There was a problem hiding this comment.
peft_path与lora相关训练参数互斥，因此以设置lora可训练参数为例。
scripts/training/run_pt.sh
Outdated
There was a problem hiding this comment.
Some users may use the script to pre-train the model from scratch.
But with these modifications, the default behavior of script is continual training chinese-llama-2.
I think it may lead to some confusions.
I would advise keeping modules_to_save.
There was a problem hiding this comment.
I agree with your suggestion.
airaria
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following features:
device_mapparameter to address the issue of insufficient CPU memory during training.Related Issue
#110 #27