Fixed element jumps to left on scrolling when right floated #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an offset().left measurement (el_left) but it is not used. Added el_right_float variable - if true, el_left is used to position the fixed element correctly in the horizontal axis.
Sometimes elements are hidden/removed on DOM ready meaning that the initial height value can be incorrect
|
Thanks for the commits.The problem with getting the 'left' pixel position is that on browser resize it changes with centered layouts. It's best to left/right float the parent div, like: http://directlyrics.com/code/lockfixed/demo-float-right.html. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an offset().left measurement (el_left) but it is not used. Added el_right_float variable - if true, el_left is used to position the fixed element correctly in the horizontal axis.
(Yvo, does this work correctly for you without this amendment?)