Strengthens counterplay vs allergens #22973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moltijoe
reviewed
Jan 24, 2025
Comment on lines
+739
to
+747
| if(H.reagents.has_reagent(/datum/reagent/medicine/epinephrine)) | ||
| return | ||
| if(H.reagents.has_reagent(/datum/reagent/medicine/atropine)) | ||
| return | ||
| if(H.reagents.has_reagent(/datum/reagent/medicine/diphenhydramine)) | ||
| return | ||
| if(H.reagents.has_reagent(/datum/reagent/medicine/synaphydramine)) | ||
| return | ||
|
|
There was a problem hiding this comment.
why not just make a list of reagents and loop through the list checking if they have one of them?
There was a problem hiding this comment.
seems overengineered
Moltijoe
reviewed
Jan 24, 2025
| @@ -281,6 +281,9 @@ | |||
| if(DISGUST_LEVEL_DISGUSTED to INFINITY) | |||
| msg += "[t_He] look[p_s()] extremely disgusted.\n" | |||
|
|
|||
| var/datum/quirk/allergic/allergen = has_quirk(/datum/quirk/allergic) | |||
| if((allergen && reagents?.has_reagent(allergen.reagent_id)) || reagents?.has_reagent(/datum/reagent/toxin/histamine)) | |||
There was a problem hiding this comment.
could also reference the cooldown that the quirk uses to track allergic reactions
There was a problem hiding this comment.
that would be strange and inconsistent use of a variable that is not meant for that
ToasterBiome
approved these changes
Jan 28, 2025
Yogbot-13
added a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Adds a bold examine tell when someone is undergoing a allergic reaction
Epinephrine, atropine, diphenhydramine, and synaphydramine (unused) now prevent further symptoms of allergic reactions
Epinephrine now reduces current losebreath by a tenth each process, making it significantly reduce losebreath and making recovery feasible
Histamine is also affected, but not its overdose
Why is this good for the game?
Allergic reaction is pretty much instant death
Inexperienced doctors may not know what is happening, examine text will help them
Epipens are now actually useful for allergic reactions, as one would expect
Testing
Changelog
🆑
tweak: Humans undergoing allergic reactions now have a swollen face examine tell
tweak: Epinephrine, atropine, and diphenhydramine now prevent further symptoms of an allergic reaction for as long as they are in the system
tweak: Epinephrine now reduces losebreath stacks by a tenth each process, making it effective for slowly treating allergic reactions
/:cl: