Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes some parent calls to be cleaner, fixes the thick skin mutation not having proper safety checks #22974

Conversation

Gboster-0
Copy link
Contributor

Document the changes in your pull request

Made Thick skin properly check if it was actually added to the DNA before giving its buffs, same with it checking for removal

Changed some if(..())'s with . = ..(); if(.) since its a bit cleaner and if any new mutations get coded in that are children of previous mutations, that can cause the children to always return false on their checks regardless if they were removed or not (not great)

Only touched yogstation files with the above change, as it isn't too big of a deal most of the time, rather its a neat convinience

Why is this good for the game?

Small bug fix gud

Changelog

🆑
bugfix: Thick skin now properly checks if its actually removed before removing its effects
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Jan 31, 2025
@Oblisk234
Copy link
Member

Does this fix #21183, and if so, can you add "Fixes #21183" to your PR description?

@Gboster-0
Copy link
Contributor Author

Does this fix #21183, and if so, can you add "Fixes #21183" to your PR description?

I got absolutelly no clue

@ToasterBiome ToasterBiome merged commit fef2a63 into yogstation13:master Feb 1, 2025
15 checks passed
Yogbot-13 added a commit that referenced this pull request Feb 1, 2025
@Gboster-0 Gboster-0 deleted the THERE-ARE-HULKS-IN-YOUR-WALLS-THERE-ARE-HULKS-IN-YOUR-WALLS branch February 1, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This fixes an issue. Please link issues in fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants