Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distribution] Add support for Python #338

Closed
4 tasks done
carstencodes opened this issue Jun 16, 2023 · 3 comments · Fixed by #358
Closed
4 tasks done

[Distribution] Add support for Python #338

carstencodes opened this issue Jun 16, 2023 · 3 comments · Fixed by #358

Comments

@carstencodes
Copy link
Contributor

carstencodes commented Jun 16, 2023

When building python protobuf serializers, gRPC services or grpc clients, the proto files are actually generated during the build using the Protobuf collection.

This project is already shipping a maven package. It should be possible to ship a wheel package as well.

Steps to take:

  • Add packaging information for a python wheel
  • Add a module index for running as a python module.
  • Pack wheel package after go-releaser has run
  • Upload wheel package to pypi.org

I could help with the first three bullet points. I think the last point is up to the maintainer.

@carstencodes
Copy link
Contributor Author

I think it might be the same as #316. mypy itself is a static type checker for python, I think, @imanazari70 thinks of pypi.org / wheels

@carstencodes
Copy link
Contributor Author

This will imply a TOML parser, as modern python projects mostly rely on pyproject.toml.

In #347, it was implemented to use different config sources like json or yaml, so I assume is required for this.

carstencodes added a commit to carstencodes/protolint that referenced this issue Dec 18, 2023
In yoheimuta#338 the distribution of python wheels is requested.

Python relies according to PEP 518 on pyproject.toml
allowing to add a [tools] table with all config values.

The pyproject.toml can now be added as a valid project
configuration source.
carstencodes added a commit to carstencodes/protolint that referenced this issue Dec 18, 2023
In yoheimuta#338 Python support is requested. Documentation has been added.
carstencodes added a commit to carstencodes/protolint that referenced this issue Dec 18, 2023
In yoheimuta#338 Python support is requested. This upload step
should perform the upload step
@carstencodes
Copy link
Contributor Author

I see the package name is already taken (and orphaned).

I'll add setup a new package name and will come back to you ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant