Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Duplicate printing of non existing namespaces #378

Closed
yonahd opened this issue Nov 21, 2024 · 2 comments · Fixed by #383
Closed

Bug: Duplicate printing of non existing namespaces #378

yonahd opened this issue Nov 21, 2024 · 2 comments · Fixed by #383
Assignees
@almilaneze
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@yonahd
Copy link
Owner

yonahd commented Nov 21, 2024 •
edited
Loading

Describe the bug
Duplicate printing of non existing namespaces

To Reproduce
Steps to reproduce the behavior:
kor -n fake1,fake2 configmap
namespace [fake1] not found
namespace [fake2] not found
namespace [fake1] not found
namespace [fake2] not found
kor version: vdev

Expected behavior
kor -n fake1,fake2 configmap
namespace [fake1] not found
namespace [fake2] not found
kor version: vdev

OS version, architecture and kor version
Darwin x86_64
Kor version: 0.5.6
@yonahd yonahd added bug Something isn't working good first issue Good for newcomers labels Nov 21, 2024
@almilaneze
Copy link
Contributor

Hi Yonah, I can work on fixing this bug. Let me know if you are ok

@yonahd
Copy link
Owner Author

yonahd commented Nov 21, 2024

Assigned

@almilaneze almilaneze mentioned this issue Nov 28, 2024
Merged
4 tasks
@yonahd yonahd linked a pull request Nov 29, 2024 that will close this issue
Fix: Removes duplicate printing of the included namespaces #383
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almilaneze almilaneze

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Removes duplicate printing of the included namespaces almilaneze/kor
2 participants
@almilaneze @yonahd