Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removes duplicate printing of the included namespaces #383

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

almilaneze
Copy link
Contributor

@almilaneze almilaneze commented Nov 28, 2024

What this PR does / why we need it?

  • Removes duplicate printing of the non existing included namespaces (which comes from the duplicated namespaces).
  • Removes unnecessary variables initialization.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

#378
Closes [XX-XX]

Notes for your reviewers

			Removes unnecessary variables initialization
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.39%. Comparing base (9cd0aba) to head (ca45220).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/filters/options.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   43.38%   43.39%   +0.01%     
==========================================
  Files          63       63              
  Lines        4020     4019       -1     
==========================================
  Hits         1744     1744              
+ Misses       2030     2029       -1     
  Partials      246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd linked an issue Nov 29, 2024 that may be closed by this pull request
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@almilaneze looks like it fixes the issue
Couple of comments

pkg/filters/options.go Show resolved Hide resolved
pkg/filters/options.go Show resolved Hide resolved
@yonahd yonahd merged commit 050c06d into yonahd:main Dec 2, 2024
1 check passed
@yonahd
Copy link
Owner

yonahd commented Dec 2, 2024

LGTM!
Merged

@almilaneze almilaneze deleted the duplicate_print branch December 2, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Duplicate printing of non existing namespaces
3 participants