We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug If using cli with -l/--exclude-labels flag, the filtering is not working
-l/--exclude-labels
To Reproduce Steps to reproduce the behavior: Resource labels:
kubectl get pvc -n default pvc-claim-2 -o jsonpath={.metadata.labels} {"kor/report":"false","reporting":"no"}
Command:
kor -l reporting=no persistentvolumeclaim
Output:
kor version: vdev _ _____ ____ | |/ / _ \| _ \ | ' / | | | |_) | | . \ |_| | _ < |_|\_\___/|_| \_\ Unused resources in namespace: "default" +---+---------------+---------------+ | # | RESOURCE TYPE | RESOURCE NAME | +---+---------------+---------------+ | 1 | Pvc | pvc-claim-2 | +---+---------------+---------------+
Expected behavior The resources shouldn't be matched but the output is the following:
kor --exclude-labels reporting=no persistentvolumeclaim kor version: vdev _ _____ ____ | |/ / _ \| _ \ | ' / | | | |_) | | . \ |_| | _ < |_|\_\___/|_| \_\ Unused resources in namespace: "default" +---+---------------+---------------+ | # | RESOURCE TYPE | RESOURCE NAME | +---+---------------+---------------+ | 1 | Pvc | pvc-claim-2 | +---+---------------+---------------+
OS version, architecture and kor version Darwin_arm64 Kor version: vdev (brew installation of stable version 0.5.6)
The text was updated successfully, but these errors were encountered:
Marking this as a bug @nemcikjan in the meantime can you try this https://github.com/yonahd/kor?tab=readme-ov-file#ignore-resources This should help exclude the resource
Sorry, something went wrong.
@yonahd the default label for excluding is working
/assign Not all resources were refactored with the new filtering interface, I'll create a PR for that.
doronkg
Successfully merging a pull request may close this issue.
Describe the bug
If using cli with
-l/--exclude-labels
flag, the filtering is not workingTo Reproduce
Steps to reproduce the behavior:
Resource labels:
Command:
Output:
Expected behavior
The resources shouldn't be matched but the output is the following:
OS version, architecture and kor version
Darwin_arm64
Kor version: vdev (brew installation of stable version 0.5.6)
The text was updated successfully, but these errors were encountered: