Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use new filter framework #387

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

doronkg
Copy link
Contributor

@doronkg doronkg commented Dec 3, 2024

What this PR does / why we need it?

This PR refactors multiple resources that still used the old filtering method, resulting in filters not being applied upon them.
In addition, not all resources supported the kor/used=false exclusion.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

Closes #384

Notes for your reviewers

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 43.32%. Comparing base (050c06d) to head (2bba13d).

Files with missing lines Patch % Lines
pkg/kor/crds.go 0.00% 5 Missing ⚠️
pkg/kor/replicaset.go 0.00% 3 Missing and 1 partial ⚠️
pkg/kor/rolebindings.go 0.00% 3 Missing and 1 partial ⚠️
pkg/kor/storageclasses.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   43.39%   43.32%   -0.08%     
==========================================
  Files          63       63              
  Lines        4019     4035      +16     
==========================================
+ Hits         1744     1748       +4     
- Misses       2029     2039      +10     
- Partials      246      248       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit b6614f3 into yonahd:main Dec 3, 2024
1 check passed
@doronkg doronkg deleted the refactor/filters branch December 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excluding labels doesn't work
3 participants