fix: ClusterRole Aggregation #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregation" This reverts commit e5ea3e7.
|
Hi @sempex |
Sure will try to add one 👍 |
|
@yonahd I added my changes to the testcases |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 47.48% 47.58% +0.09%
==========================================
Files 32 32
Lines 2883 2915 +32
==========================================
+ Hits 1369 1387 +18
- Misses 1345 1354 +9
- Partials 169 174 +5 ☔ View full report in Codecov by Sentry. |
yonahd
reviewed
Mar 11, 2024
Fixed it 🚀 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes Supports ClusterRole Aggregation, enabling the aggregation of one ClusterRole into another. For more details, refer to the official Kubernetes Documentation here.
This functionality allows a ClusterRole lacking a ClusterRoleBinding or a RoleBinding to remain usable. Currently, Kor does not handle this scenario. Consequently, the ClusterRoles in use are not properly listed through Kor. The proposed Pull Request addresses this issue.