docs: add values.yaml descriptions to README.md #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 40.84% 40.84%
=======================================
Files 58 58
Lines 2904 2904
=======================================
Hits 1186 1186
Misses 1530 1530
Partials 188 188 ☔ View full report in Codecov by Sentry. |
yonahd
reviewed
May 22, 2024
|
Good catch! Thanks! |
yonahd
reviewed
May 22, 2024
Co-authored-by: Yonah Dissen <[email protected]>
|
Sorry to bother, but the Readme needs to be regenerated 😬 |
No bother, laughing out loud... Should've catched that myself. Thanks for taking the review seriously! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
This PR adds the descriptions from the
values.yamlfile to theREADME.mdusing Helm docs. I bumped the Chart version since I made changes to the Chart's docs. I also cleaned up theChart.yamlfile and improved the description.PR Checklist
Github Issue
[XX-XX]
Notes for your reviewers