support json response as cli output

[Yuni-sa]

to solve #35
@yonahd

[Yuni-sa]

only problem i've noticed when testing is that the json output for hpas is different when no unused hpas are found because of a difference in the JSON functions.

output for no unused hpas is:

{}

all other resources when there none unused return something like:

{
  "kor": {
    "Deployments": null
  }
}

refactoring the json outputs to one standard should probably be discussed in a different issue.

[Yuni-sa]

refactoring the json outputs to one standard should probably be discussed in a different issue.

also some returning null and some returning an empty array:

{
  "default": {
    "ConfigMap": [],
    "Deployment": null,
    "Hpa": null,
    "Ingress": [],
    "Pvc": [],
    "Role": [],
    "Secret": [],
    "Service": null,
    "ServiceAccount": [],
    "Statefulset": null
  }
}

[Yuni-sa]

I can also add fmt.Fprintf(os.Stderr, "Failed to process namespace %s: %v\n", namespace, err) to the cmd functions for better formatting.
@yonahd update me on what you think.

[yonahd]

only problem i've noticed when testing is that the json output for hpas is different when no unused hpas are found because of a difference in the JSON functions.

output for no unused hpas is:

{}

all other resources when there none unused return something like:

{
  "kor": {
    "Deployments": null
  }
}

refactoring the json outputs to one standard should probably be discussed in a different issue.

Won't this be cleaned up by the MR?

[yonahd]

I'll open an issue to align the json responses

[yonahd]

I can also add fmt.Fprintf(os.Stderr, "Failed to process namespace %s: %v\n", namespace, err) to the cmd functions for better formatting. @yonahd update me on what you think.

@Yuni-sa
You mean the tabular response command?

[yonahd]

@Yuni-sa would you like to add this to the MR or should I leave it as a separate issue? #44

[Yuni-sa]

Won't this be cleaned up by the MR?

no because only GetUnusedHpasJson() uses if len(diff) > 0 before adding the response to the map while all of the other json functions don't.

I think we should handle everything else in different issues and close this one.
@yonahd

[yonahd]

@Yuni-sa would you like to add this to the MR or should I leave it as a separate issue? #44

Keeping as separate issue

[Yuni-sa]

I'll open an issue to align the json responses

as this got closed by #39

@Yuni-sa would you like to add this to the MR or should I leave it as a separate issue? #44

and this is being handled by #44

@yonahd anything more I should fix/add for this pr to be reviewed and merged?

[yonahd]

LGTM