Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option for podAnnotations on the deployment level #376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DMSwimTech
Copy link

What this PR does / why we need it?

Currently the project support integration with Prometheus out of the box. To allow other provider such Datadog to collect metric we need to provide podAnnotation field Datadog annotations integration

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

Closes [XX-XX]

Notes for your reviewers

@yonahd
Copy link
Owner

yonahd commented Nov 6, 2024

@DMSwimTech Thanks for the contribution.
Can you bump the chart version?
This is a requirement for any chart changes

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.38%. Comparing base (9cd0aba) to head (0f4d310).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   43.38%   43.38%           
=======================================
  Files          63       63           
  Lines        4020     4020           
=======================================
  Hits         1744     1744           
  Misses       2030     2030           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants