Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables to get multiple specific unused resources #57

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Enables to get multiple specific unused resources #57

merged 2 commits into from
Sep 10, 2023

Conversation

Yuni-sa
Copy link
Contributor

@Yuni-sa Yuni-sa commented Sep 6, 2023

to solve #2

rootcmd now calls for GetUnusedMulti and GetUnusedMultiStructured when it indicates a list of resources, multi.go uses functions like getUnusedSVCs from all.go.

@yonahd let me know what you think and also if --exclude-resource for all.go should be in this PR.

@yonahd
Copy link
Owner

yonahd commented Sep 6, 2023

Thanks for the MR, I'll review it hopefully in the next few days.
Regarding exclude-resource, I feel like it's an unnecessary option.

@yonahd yonahd requested review from luisdavim and yonahd September 6, 2023 18:42
luisdavim
luisdavim approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit cf47842 into yonahd:main Sep 10, 2023
@yonahd yonahd linked an issue Sep 10, 2023 that may be closed by this pull request
Allow selecting specific resources #2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisdavim luisdavim luisdavim approved these changes

@yonahd yonahd Awaiting requested review from yonahd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow selecting specific resources
3 participants
@Yuni-sa @yonahd @luisdavim