Copy cachedGroup.children and write back only once

yonaskolb · Sep 21, 2019 · 0dc4a8d · 0dc4a8d
1 parent fa8c715
commit 0dc4a8d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Sources/XcodeGenKit/SourceGenerator.swift b/Sources/XcodeGenKit/SourceGenerator.swift
@@ -242,12 +242,14 @@ class SourceGenerator {
         let groupReference: PBXGroup
 
         if let cachedGroup = groupsByPath[path] {
+            var cachedGroupChildren = cachedGroup.children
             for child in children {
                 // only add the children that aren't already in the cachedGroup
-                if !cachedGroup.children.contains(where: { $0.path == child.path }) {
-                    cachedGroup.children.append(child)
+                if !cachedGroupChildren.contains(where: { $0.path == child.path }) {
+                    cachedGroupChildren.append(child)
                 }
             }
+            cachedGroup.children = cachedGroupChildren
             groupReference = cachedGroup
         } else {