Skip to content

Commit

Permalink
Merge pull request #751 from PycKamil/use_relative_path_for_XcodeProj
Browse files Browse the repository at this point in the history
Use full path for XcodeProj
  • Loading branch information
yonaskolb authored Jan 12, 2020
2 parents 308b351 + 74203dc commit 480477a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#### Fixed
- Fixed resolving a relative path for `projectReference.path` [#740](https://github.com/yonaskolb/XcodeGen/pull/740) @kateinoigakukun
- Don't add framework dependency's directory to `FRAMEWORK_SEARCH_PATHS` if it is implicit [#744](https://github.com/yonaskolb/XcodeGen/pull/744) @ikesyo @yutailang0119
- Fixed resolving relative path passed to `XcodeProj` [#751](https://github.com/yonaskolb/XcodeGen/pull/751) @PycKamil

#### Internal
- Update to SwiftCLI 6.0 and use the new property wrappers [#749](https://github.com/yonaskolb/XcodeGen/pull/749) @yonaskolb
Expand Down
3 changes: 2 additions & 1 deletion Sources/XcodeGenKit/SchemeGenerator.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Foundation
import ProjectSpec
import XcodeProj
import PathKit

private func suitableConfig(for type: ConfigType, in project: Project) -> Config {
if let defaultConfig = Config.defaultConfigs.first(where: { $0.type == type }),
Expand Down Expand Up @@ -34,7 +35,7 @@ public class SchemeGenerator {
if let cachedProject = projects[reference] {
return cachedProject
}
let pbxproj = try XcodeProj(pathString: reference.path).pbxproj
let pbxproj = try XcodeProj(path: project.basePath + Path(reference.path)).pbxproj
projects[reference] = pbxproj
return pbxproj
}
Expand Down

0 comments on commit 480477a

Please sign in to comment.