Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating Info.plist overwrites path specified in settings>configs #440

Closed
feischl97 opened this issue Nov 19, 2018 · 1 comment
Closed

Comments

@feischl97
Copy link
Contributor

I have a project where a target has different configs. One of those configs uses a different Info.plist than the others.
When I create a Info.plist with xcodegen it overwrites every config with the generated one, even if I have specified a path for it via INFOPLIST_FILE build setting.

Example: In this case Predifined.plist for debug gets overwritten with Generated.plist.
plistoverwrite

Suggestion: When there is a path for a predefined plist set, do not overwrite it with the created one.

Related issues: #207, #406

@yonaskolb
Copy link
Owner

The generated info plist was designed to be a simple way to set info plist properties without creating your own. For more complex cases custom settings can be set per config that point to existing files.
Having said that there's no reason that we shouldn't allow the INFOPLIST_PATH to be overwritten by custom settings, like you've done here. So yes, this can be changed 👍
The automatic INFOPLIST_PATH that is set by looking into the source files would still be overriden by the info property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants