Don't overwrite INFOPLIST_FILE setting with info path #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
reviewed
Nov 23, 2018
There was a problem hiding this comment.
Thanks @feischl97!
It would be great if you can add a changelog entry, and also a test.
The test can go after this one, but be called info doesn't override info.plist setting
https://github.com/yonaskolb/XcodeGen/blob/master/Tests/XcodeGenKitTests/ProjectGeneratorTests.swift#L855
The setup will be similar but adding a custom INFOPLIST_FILE setting, and then checking that the targetConfig still has that value.
yonaskolb
changed the title
|
Ok I will look into it! 👍 |
yonaskolb
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #440.
Just added a check if for a config INFOPLIST_FILE is already set in settings. If it is it will not be overwritten with the generated Info.plist.
I also updated projectspec.md to reflect this change.
I did not add any tests, are they necessary?