Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultConfigurationName to options #269

Merged
merged 3 commits into from
Mar 19, 2018

Conversation

keith
Copy link
Collaborator

@keith keith commented Mar 19, 2018

This allows users to set the defaultConfigurationName project wide. This
setting corresponds to the drop down in the project settings that says
"Use CONFIG for command line builds". This affects which configuration
Xcode looks in for some settings, even if you pass -configuration FOO.

@keith keith requested review from kastiglione and yonaskolb March 19, 2018 20:17
Copy link
Collaborator

@kastiglione kastiglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -80,6 +80,7 @@ Note that target names can also be changed by adding a `name` property to a targ
- [ ] **deploymentTarget**: **[[Platform](#platform): String]** - A project wide deployment target can be specified for each platform otherwise the default SDK version in Xcode will be used. This will be overridden by any custom build settings that set the deployment target eg `IPHONEOS_DEPLOYMENT_TARGET`. Target specific deployment targets can also be set with [Target](#target).deploymentTarget.
- [ ] **disabledValidations**: **[String]** - A list of validations that can be disabled if they're too strict for your use case. By default this is set to an empty array. Currently these are the available options:
- `missingConfigs`: Disable errors for configurations in yaml files that don't exist in the project itself. This can be useful if you include the same yaml file in different projects
- [ ] **defaultConfigurationName**: **String** - The default configuration to for command line builds from Xcode. If the configuration provided here doesn't match one in your [configs](#configs) key, XcodeGen will fail. If you don't set this, the first configuration alphabetically will be chosen.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration to for command line builds

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@keith keith force-pushed the ks/defaultConfigurationName branch from 3837777 to 11559f7 Compare March 19, 2018 20:32
keith added 2 commits March 19, 2018 13:47
This allows users to set the defaultConfigurationName project wide. This
setting corresponds to the drop down in the project settings that says
"Use CONFIG for command line builds". This affects which configuration
Xcode looks in for some settings, even if you pass `-configuration FOO`.
@keith keith force-pushed the ks/defaultConfigurationName branch from 11559f7 to b1d739d Compare March 19, 2018 20:47
@yonaskolb
Copy link
Owner

Nice one, thanks @keith!
How about the name defaultConfig? This would match our existing configuration usage

@keith
Copy link
Collaborator Author

keith commented Mar 19, 2018

Renamed to defaultConfig

@yonaskolb
Copy link
Owner

👏

@yonaskolb yonaskolb merged commit 9ebb927 into master Mar 19, 2018
@yonaskolb yonaskolb deleted the ks/defaultConfigurationName branch March 19, 2018 23:38
@keith
Copy link
Collaborator Author

keith commented Mar 19, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants