Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change group sorting #356

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Change group sorting #356

merged 4 commits into from
Jul 24, 2018

Conversation

yonaskolb
Copy link
Owner

@yonaskolb yonaskolb commented Jul 23, 2018 •
edited
Loading

This tweaks the sorting of groups and files in 2 ways

  • Groups like Frameworks and Products are added to the end of the top level groups
  • Groups are sorted after other files by default
  • Added new options.groupSortPosition

Resolves #292

@yonaskolb yonaskolb mentioned this pull request Jul 23, 2018
Closed
brentleyjones
brentleyjones approved these changes Jul 23, 2018
View reviewed changes
Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nice. Though, the common pattern, at least after the root level, is to have groups sorted above files. I bet I could get used to it, but I'm sure I'll hear complaints from my devs about this 😉.

@yonaskolb
Copy link
Owner Author

yonaskolb commented Jul 23, 2018 •
edited
Loading

@brentleyjones I'm in agreement with you, but after looking at other projects, and seeing what Xcode does by default (also after sort by types), it seems this is more common. If it's an issue we can add an option

@yonaskolb
Copy link
Owner Author

yonaskolb commented Jul 24, 2018 •
edited
Loading

I've added options.groupSortPosition of either top, bottom or none. Defaults to bottom which is different than before this PR

@yonaskolb yonaskolb merged commit b805882 into master Jul 24, 2018
@yonaskolb yonaskolb deleted the sorting branch July 24, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonaskolb @brentleyjones