-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate optional info plist and entitlements #415
Conversation
I've just tested this functionality by adding the following to my app.yml:
I was expecting the entitlements file to be generated without defining a path - it wasn't so I added a path like so:
This works well and I appreciate why giving a file name is helpful. Otherwise this is great, thanks again 👍 |
I’ll review this tonight. Looks neat! Sent with GitHawk |
defaultInfoPlist["CFBundleName"] = "$(PRODUCT_NAME)" | ||
defaultInfoPlist["CFBundleDevelopmentRegion"] = "$(DEVELOPMENT_LANGUAGE)" | ||
defaultInfoPlist["CFBundleShortVersionString"] = "1.0" | ||
defaultInfoPlist["CFBundleVersion"] = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be stored in a static property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could indeed. I'll refactor this stuff out into a InfoPlistGenerator
as well
@yonaskolb I've just deleted my previous comments as I've got things working with a few additional yml files. Is this likely to merge soon? - i'd like to start using this on my build servers. |
I'll work on this this weekend and get everything up to scratch. I'd like to add it to the next release.
We couldn't make any good guesses about where to generate this path, so it's a required property for now
Yep, this should throw an error. I'll add this |
0af8843
to
f651560
Compare
f651560
to
26106a0
Compare
@lukewakeford completed. Note that |
f4632c4
to
0089dd2
Compare
Resolves #406
This allows an
Info.plist
or.entitlements
file to be generated per target via the project spec.Some basic attributes are generated by default, but app specific ones are not for now.
This features is powerful when used in combination with
include
andtargetTemplates
.