Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sdkRoot" option for Dependency #429

Closed
wants to merge 1 commit into from

Conversation

hayatan
Copy link

@hayatan hayatan commented Nov 2, 2018

Whether the framework is an library under the SDKROOT directory. Defaults to false.

ex.

if you want link $(SDKROOT)/System/Library/Frameworks/StoreKit.framework

- framework: System/Library/Frameworks/StoreKit.framework
  embed: false
  sdkRoot: true

Whether the framework is an library under the SDKROOT directory. Defaults to false.

ex.

if you want link `$(SDKROOT)/System/Library/Frameworks/StoreKit.framework`

```
- framework: System/Library/Frameworks/StoreKit.framework
  embed: false
  sdkRoot: true
```
@yonaskolb
Copy link
Owner

Hi @hayatan, thank you for you PR!
I'd like to solve this slightly differently, and that is to have a new dependency type called sdk that joins the existing framework, carthage and target types. Are you happy to implement that?
This solves this issue #11

@hayatan
Copy link
Author

hayatan commented Nov 2, 2018

Hi @yonaskolb
I did not notice that Issue. Your solution is very good.
I will withdraw this pull request.
Thank you.

@hayatan hayatan closed this Nov 2, 2018
@yonaskolb
Copy link
Owner

yonaskolb commented Nov 2, 2018

A PR has been opened here #430
Does this meet your needs?

@yonaskolb
Copy link
Owner

This is now been merged and released with 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants