-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for customizing attributes on a target source file #583
Conversation
@yonaskolb this is the last remaining issue after migrating our app to xcodegen. not sure if this is the correct solution, would love sone feedback . |
Thanks for the PR @min! |
@yonaskolb That makes sense, changed to a |
@yonaskolb would love to get this merged in as we're using a forked version for now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @min, I've just been so busy. I left a single comment. Could you also add a changelog entry? Then we can get this merged 👍
Co-Authored-By: Yonas Kolb <[email protected]>
@yonaskolb all set |
CHANGELOG.md
Outdated
@@ -2,10 +2,9 @@ | |||
|
|||
## Next Version | |||
|
|||
#### Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was removing this heading an accident? Let's keep it around. It's fine to remove the blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yonaskolb that was a merge error, should be fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for this @min!
When adding to an intents definition file to a target, Xcode will do some code gen at build time. In some cases we need to add the definition file to multiple targets (shared frameworks), but only have the code generation happen for one of the targets to avoid duplicated code.
Per apple docs:
This adds a
noCoden
property to target source which internal setssettings = {ATTRIBUTES = (no_codegen, ); };
on the intents definition PBXBuildFile.